-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor: Eligibility API config models #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2973c95 to
8d04366
Compare
|
Resolved. Forgot that the group IDs needed to be updated in my local config. |
|
Also note that this PR doesn't have anything to do with Enrollment, so I wouldn't expect that to necessarily be a part of the review process. Glad you got it sorted though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working well! I left a few non-blocking questions and comments inline.
P.S.: I did also run the migration against a DB initiated on main and the data was migrated as expected.
benefits/core/migrations/0065_refactor_eligibilityapiverificationrequest.py
Show resolved
Hide resolved
replace EnrollmentFlow optional config fields with an optional foreign key
refactor EnrollmentFlow.clean() to use the new api_request field
replace TransitAgency optional config fields with an optional foreign key
clean up field checks on TransitAgency ModelAdmin
8d04366 to
38d75d3
Compare
|
Preview url: https://benefits-3232--cal-itp-previews.netlify.app |
Closes #2780
What this PR does
EligibilityApiConfigfor agency-specific Eligibility API data (public/private client keys)TransitAgencywith Eligibility API configTransitAgency, adds optional foreign key toEligibilityApiConfigEligibilityApiVerificationRequestfor flow-specific Eligibility API data (keys, JWT config)EnrollmentFlowwith Eligibility API configEnrollmentFlow, adds optional foreign key toEligibilityApiVerificationRequestThe idea is to make configuration of flows simpler going forward, as we don't expect to use this API for new flows, simply maintaining the existing 2 in production (MST Courtesy Cards, SBMTD Reduced Fare Mobility ID).
The
EligibilityApiConfigchanges weren't necessarily spelled out in #2780. However they are similar enough, and similarly meant to make theTransitAgencyconfiguration experience simpler for agencies going forward.Testing the PR
User flow
local_fixtures.jsonfrom the branchAdmin (superuser)
Admin (Cal-ITP user)